-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dec and Jan workshops #504
Conversation
Reviewer Checklist
|
December 15 link seems to be empty? https://github.com/nih-cfde/training-and-engagement/wiki/A-Hands-On-Introduction-to-AWS:-December-15,-2021%22 |
Ah, I was missing an opening quote. Should work now. |
A couple questions before I sign off on these:
|
Excellent points @jeremywalter. You are correct. The :::success, :::failure, and [TOC] things do not render in GitHub as these are features of HackMD. When I started adding workshops, I saw that other workshops had left all the formatting, including links to surveys, as is, so I have deleted that. If you look at PR #499, you will see similar record of the UNIX and AWS workshops where all the :::success, :::failure, and [TOC] formatting is intact so that when you start a new hackmd from the template, you get at the formatting. There, however, I have taken most of the survey links out so they have to be added for each new workshop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trust the @raynamharris what could go wrong he asked
ah merge conflicts sigh |
PR Checklist
PR Description
Adds links to wiki pages for the UNIX and AWS workshops taught in Dec 2021 and Jan 2022
Preview link
https://cfde-training-and-engagement--504.com.readthedocs.build/en/504/
Review format
Comments welcome