Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dec and Jan workshops #504

Merged
merged 3 commits into from
Feb 15, 2022
Merged

add Dec and Jan workshops #504

merged 3 commits into from
Feb 15, 2022

Conversation

raynamharris
Copy link
Contributor

@raynamharris raynamharris commented Jan 28, 2022

PR Checklist

PR Description

Adds links to wiki pages for the UNIX and AWS workshops taught in Dec 2021 and Jan 2022

Preview link

https://cfde-training-and-engagement--504.com.readthedocs.build/en/504/

Review format

Comments welcome

@github-actions
Copy link

Reviewer Checklist

  • spelling and grammar
  • successful run of all installation and code chunks
  • sufficient explanation and details for the tutorial content
  • code syntax and naming convention
  • adherence of tutorial format to style guide
  • functional links (inter and intra)
  • accessible hyperlink text

@jeremywalter
Copy link
Contributor

@raynamharris
Copy link
Contributor Author

Ah, I was missing an opening quote. Should work now.

@jeremywalter
Copy link
Contributor

A couple questions before I sign off on these:

  1. There are some widgets or something that aren't rendering in the preview (the show ups as :::success and :::failure and there is even a [TOC]. -- Do we care about these enough to 'fix' them if they need to be fixed? Especially considering that these are 'supplementary' materials we are providing for attendees?
  2. The survey links are still in there... should we remove them and make that part of the SOP? I don't think it would ever be a big problem, but might be good practice anyway.

@raynamharris
Copy link
Contributor Author

Excellent points @jeremywalter.

You are correct. The :::success, :::failure, and [TOC] things do not render in GitHub as these are features of HackMD. When I started adding workshops, I saw that other workshops had left all the formatting, including links to surveys, as is, so I have deleted that.

If you look at PR #499, you will see similar record of the UNIX and AWS workshops where all the :::success, :::failure, and [TOC] formatting is intact so that when you start a new hackmd from the template, you get at the formatting. There, however, I have taken most of the survey links out so they have to be added for each new workshop.

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust the @raynamharris what could go wrong he asked

@raynamharris raynamharris merged commit e4d8423 into dev Feb 15, 2022
@raynamharris raynamharris deleted the add-workshops-dec-jan branch February 15, 2022 20:10
@raynamharris
Copy link
Contributor Author

ah merge conflicts sigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants