Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes, QOL, info logging, reading squad robustness #20

Open
wants to merge 8 commits into
base: feature/documentation-and-qol
Choose a base branch
from

Conversation

jacobalbano
Copy link

A major feature of this pull request is the addition of an info log channel (#server_log on NTE ) and diagnostic messages which will be posted there in case of errors. Currently, the mute command is not applying roles correctly and the reading squad automation has started to suffer occasional glitches. Both of these areas have had info logging added to them so we can diagnose what's going on.

Itemized changes:

  • Fixed a typo in the setup script that would store the mute role ID with the wrong key
  • Added a ban command (permission level "high")
  • Added a command to manually trigger the reading squad deadline
  • Enabled REST mode in the Eris settings (this allows us to load details for a user who has left the server; used by the mute, rapsheet commands etc)
  • Modified several commands to send "(bot name) is typing" during actions which may take some time to complete
  • Fixed an edge case in reading squad automation where the database would not be properly cleared if a squad member left the server

TheCyberRonin and others added 8 commits February 21, 2021 15:24
- Mute, warn rapsheet, info commands now work even if the user has left the server
- Added command to manually reset reading squad
- Robustness and error logging for reading squad
- Fixed typo in setup script
- Enabled REST mode (necessary to get nonlocal user info)
- Added "is typing" feedback to commands which may take time to execute
ESlint fixes (mostly indentation and line endings)
NPM audit (nothing we can do about nedb's underscore vulnerability)
Removed all traces of reading squad automation (now being handled by https://github.com/jacobalbano/Shisho)
Removed code regarding warn role
Removed everything that used kanjiAPI (uses a defunct website)
Ban, warn, and mute commands now support plain IDs in addition to mentions
Setup script now handles ontopic role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants