Formating and explain in more javadoc

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/ConstantNullVector.java

@@ -48,12 +48,6 @@ public OrdinalBytesRefVector asOrdinals() {
         throw new UnsupportedOperationException("null vector");
     }
 
-    @Override
-    public ToMask toMask() {
-        assert false : "null vector";
-        throw new UnsupportedOperationException("null vector");
-    }
-
     @Override
     public ConstantNullVector filter(int... positions) {
         assert false : "null vector";

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-ArrayBlock.java.st

@@ -103,10 +103,6 @@ $if(BytesRef)$
     }
 
 $elseif(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
     @Override
     public ToMask toMask() {
         if (getPositionCount() == 0) {

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-ArrayVector.java.st

@@ -130,19 +130,8 @@ $if(BytesRef)$
     public OrdinalBytesRefVector asOrdinals() {
         return null;
     }
-
-$elseif(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
-    @Override
-    public ToMask toMask() {
-        incRef();
-        return new ToMask(this, false);
-    }
-
 $endif$
+
 $if(BytesRef)$
     @Override
     public BytesRef getBytesRef(int position, BytesRef dest) {

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-BigArrayBlock.java.st

@@ -87,10 +87,6 @@ public final class $Type$BigArrayBlock extends AbstractArrayBlock implements $Ty
     }
 
 $if(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
     @Override
     public ToMask toMask() {
         if (getPositionCount() == 0) {

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-BigArrayVector.java.st

@@ -84,18 +84,6 @@ $endif$
         return new $Type$VectorBlock(this);
     }
 
-$if(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
-    @Override
-    public ToMask toMask() {
-        incRef();
-        return new ToMask(this, false);
-    }
-$endif$
-
     @Override
     public $type$ get$Type$(int position) {
         return values.get(position);

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-Block.java.st

@@ -67,7 +67,8 @@ $if(BytesRef)$
 $elseif(boolean)$
     /**
      * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
+     * passing to {@link #keepMask}. Null and multivalued positions will be
+     * converted to {@code false}.
      */
     ToMask toMask();
 

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-ConstantVector.java.st

@@ -59,19 +59,8 @@ $if(BytesRef)$
     public OrdinalBytesRefVector asOrdinals() {
         return null;
     }
-
-$elseif(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
-    @Override
-    public ToMask toMask() {
-        incRef();
-        return new ToMask(this, false);
-    }
-
 $endif$
+
     @Override
     public $Type$Vector filter(int... positions) {
         return blockFactory().newConstant$Type$Vector(value, positions.length);

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-Vector.java.st

@@ -52,13 +52,6 @@ $if(BytesRef)$
      */
     OrdinalBytesRefVector asOrdinals();
 
-$elseif(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
-    ToMask toMask();
-
 $endif$
     @Override
     $Type$Vector filter(int... positions);

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-VectorBlock.java.st

@@ -46,13 +46,10 @@ $if(BytesRef)$
     }
 
 $elseif(boolean)$
-    /**
-     * Convert this to a {@link BooleanVector "mask"} that's appropriate for
-     * passing to {@link #keepMask}.
-     */
     @Override
     public ToMask toMask() {
-        return vector.toMask();
+        vector.incRef();
+        return new ToMask(vector, false);
     }
 
 $endif$

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/data/BasicBlockTests.java

@@ -832,10 +832,7 @@ public void testBooleanBlock() {
             IntStream.range(0, positionCount).mapToObj(ii -> randomBoolean()).forEach(vectorBuilder::appendBoolean);
             BooleanVector vector = vectorBuilder.build();
             assertSingleValueDenseBlock(vector.asBlock());
-            try (ToMask mask = vector.toMask()) {
-                assertThat(mask.hadMultivaluedFields(), equalTo(false));
-                assertThat(mask.mask(), sameInstance(vector));
-            }
+            assertToMask(vector);
             releaseAndAssertBreaker(vector.asBlock());
         }
     }
@@ -1422,7 +1419,7 @@ static void assertToMaskZeroPositions(BooleanBlock block) {
     }
 
     static void assertToMask(BooleanVector vector) {
-        try (ToMask mask = vector.toMask()) {
+        try (ToMask mask = vector.asBlock().toMask()) {
             assertThat(mask.mask(), sameInstance(vector));
             assertThat(mask.hadMultivaluedFields(), equalTo(false));
         }