Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve getConsumer #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

improve getConsumer #7

wants to merge 6 commits into from

Conversation

nikam14
Copy link
Owner

@nikam14 nikam14 commented Sep 26, 2024

Motivation

In contextImpl.java the getConsumer() - When trying to get partitioned topic consumer it throws error consumer not found.
Instead show error message that partitioned topic not present.
Also reduces computation to search for consumer.

Modifications

Added a boolean var to check partitioned topic present or not.
when try to get consumer check whether partitioned topic present then proceed.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is already covered by existing tests, such as ContextImplTest.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant