changed userRecommendations api to public

[helloukey]

Change-Id: I6965296e6f9281a8516ecbe7449d71ca9c406b65

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
openmentorship	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 2, 2024 7:29pm

[helloukey]

This pull request is part of a stack:

1. changed userRecommendations api to public (#252)
2. changed searchMentors api to public (#253)
3. removed /explore route from nextAuth list (#254)
4. updated userConfirmation state and modal for join mentorship program (#255)
5. returned error for userType mentor (#256)
6. fixed layout shift for explore page mentors listing (#257)

[notion-workspace]

Make Mentor search public

[notion-workspace]

Backend deployment strategy

[nikhil-g777]

Why do we have return next() if no user and just calling next() when there is a user, shouldn't it be the same.

[nikhil-g777]

And we don't need to check for a user and assign it to req.user. That it already done when we do passport.authenticate(). Thats why in lot of the controller methods, we are already using req.user.

Basically, i think you can keep the code as it was before and just remove the util.checkRole.... line

[helloukey]

@nikhil-g777,
passport.authenticate() is doing the JWT check. So, if it cannot find the user, it throws the default error 'unauthorized' and due to this default behavior, We cannot do further functionalities.
So, basically what we are doing is:

1. Check if a user is available, if not available then normally move to the next middleware.
2. If the user is available and is a userType mentee then add the user to the req object and move to the next middleware.
3. If the user is available and is a userType mentor then return the error 'unauthorized'.