Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Upload test report to codecov #59

Merged
merged 1 commit into from
Aug 21, 2024
Merged

👷 Upload test report to codecov #59

merged 1 commit into from
Aug 21, 2024

Conversation

nikhilbadyal
Copy link
Owner

@nikhilbadyal nikhilbadyal commented Aug 21, 2024

Summary by Sourcery

Update the CI workflow to remove the report title configuration from the pytest action and add a new step to upload test reports using the phoenix-actions/test-reporting action.

CI:

  • Remove the report title configuration from the pytest action in the CI workflow.
  • Add a new step to the CI workflow to upload test reports using the phoenix-actions/test-reporting action.

@nikhilbadyal nikhilbadyal added the ci/cd👷 CI/CD Tasks label Aug 21, 2024
@nikhilbadyal nikhilbadyal self-assigned this Aug 21, 2024
Copy link

sourcery-ai bot commented Aug 21, 2024

Reviewer's Guide by Sourcery

This pull request modifies the GitHub Actions workflow file for running tests. It removes the custom report title from the pytest action and adds a new step to generate and upload test reports using the phoenix-actions/test-reporting action. The changes aim to improve the visibility and presentation of test results in the GitHub Actions interface.

File-Level Changes

Files Changes
.github/workflows/pytest.yml Removed custom report title configuration from pytest-action
.github/workflows/pytest.yml Added a new step using phoenix-actions/test-reporting to generate and upload test reports

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nikhilbadyal - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nikhilbadyal nikhilbadyal merged commit e0bbc88 into main Aug 21, 2024
7 checks passed
@nikhilbadyal nikhilbadyal deleted the report branch August 21, 2024 19:13
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b961cd5) to head (e2b1fc1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          338       338           
=========================================
  Hits           338       338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd👷 CI/CD Tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant