-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update() retains discounted_reward from previous episodes #8
Comments
Remember, the array is reversed so I think you'd need to set the discounted_reward = 0 first:
|
Thanks! |
This was referenced Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the
update()
method thediscounted_reward
is always calculated using a gamma of the previous discounted_reward, but there's no break between episodes so the reward from one episode is carried across to the next, which I assume cannot be correct.Suggest adding
terminal_states
list to the Memory class, and then setting the discounted_reward = 0 when a new episode starts.The text was updated successfully, but these errors were encountered: