Supporting node 0.11 using Nan #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some errors with not declaring a nanscope. Also not returning on errors.
Also fixed a problem where empty tag values were not being returned properly.
This means it works with 0.10 and 0.11
|
+1 any updates on this? |
|
thanks for the porting. until this gets merged, I'm using your version. tests are passing with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started working on a music app recently and wanted to use node 0.11 (I'm using Koa). So I've ported the bindings to use Nan.
Tests pass on node 0.10 and 0.11, on Ubuntu. I haven't tried on OSX or Windows.
I'm not sure if this would have been better based off another branch? Anyway, let me know and I can make any changes necessary.