Move public functions #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semicolon mistakes
rename function and class from Functions to Utils to prevent overlap in non case sensitive file systems
rename function and class from Functions to Utils to prevent overlap in non case sensitive file systems
|
I like the idea but Utils and static isn't good. Make it |
|
Yeah I don't understand the move to static functions, that does not seem to be an improvement, why do that? It also changes the API for anyone already using simpleDispatcher and cachedDispatcher as functions. Why force everyone to go and change that call? |
|
I honestly see no benefit in doing this. Closing as won't fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move from functions files to Utils abstract class and point old functions file for backward compatibility