Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinx-inventory-parser finding #17

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

n-peugnet
Copy link
Contributor

Maybe not worth adding as I am currently the only one to use this library and it is quite a silly mistake 😅. This is my first time using a fuzzer and it was a nice experience.

I have some questions regarding how to setup fuzzing in a project. I wonder if I should commit the corpus in the VCS. Here is my setup.
Also, do you think you could extend the support down to PHP 7.3? As I choose to install the Fuzzer with composer I need to bump my requirement. But no worry, of course. I can live with it.

@nikic
Copy link
Owner

nikic commented Jan 17, 2024

I have some questions regarding how to setup fuzzing in a project. I wonder if I should commit the corpus in the VCS. Here is club-1/sphinx-inventory-parser#6.

In most cases, I would not commit the corpus, and instead have a script that can generate a starting corpus from existing tests. For example https://github.com/php/php-src/blob/master/sapi/fuzzer/generate_parser_corpus.php takes existing PHP tests and just converts them into the expected format. Something like this is usually possible.

Also, do you think you could extend the support down to PHP 7.3? As I choose to install the Fuzzer with composer I need to bump my requirement. But no worry, of course. I can live with it.

I don't think so, as the project uses a lot of 7.4 features (like property types). If you don't want to increase the composer requirement, I'd recommend to use the phar file and then only run it on >= 7.4.

@nikic nikic merged commit 409e4d4 into nikic:master Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants