Add missing flag helper methods to Property and PropertyHook #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Dec 11, 2024
| /** | ||
| * @dataProvider provideModifiers | ||
| */ | ||
| public function testModifiers($modifier): void { |
There was a problem hiding this comment.
A bit complicated to test a single modifier?
There was a problem hiding this comment.
I just followed the structure of other similar tests. Maybe when in the future more modifiers are allowed, it will be easier to add tests for them.
There was a problem hiding this comment.
Fair enough. If we want to keep this we should drop the separate testIsFinal test though, because the two of them are redundant.
There was a problem hiding this comment.
Updated, thanks.
ondrejmirtes
force-pushed
the
flag-helper-methods
branch
from
aaab8ec to
ee47429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.