Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an acquisition timeout, making it possible to bail out of waiting for a connection cleanly. (Includes the changes from #16 to avoid dealing with conflicts, happy to rebase with only this change though if preferred.)
We want something like this for PostgREST (PostgREST/postgrest#2348) to be able to actively time out queries that are blocked waiting for an overloaded connection pool.
hasql-pool
:timeout
on the whole action (i.e.timeout delay $ Pool.use $ query
). Undesirable because it might mean interrupting while the query is running database server side, running into problems like returning a timeout error while postgres might still successfully apply the request.disarmableTimeout delay $ \disarm -> Pool.use $ disarm >> query
). That should work, it's just tricky to get right and pretty complicated and I'd rather avoid going there. 😬