-
Notifications
You must be signed in to change notification settings - Fork 45
Turn OpenPGP.js into driver #73
Comments
Moves to verifyBasicSignatures() Moves to getKeyID() Moves to getPerson() Moves and rewrites getAlgorithmString() Moves to exportArmored() and getKeyID() Moves to getKeyUserids() Finishes isolating OpenPGP.js functions to .crypto.js for #73
What do you have in mind regarding driver loading? Doing it in JavaScript like if(usePyPgp)
this.pgpDriver = new pypgpDriver();
else
this.pgpDriver = new openpgpjsDriver();
...
// Do some encryption
this.pgpDriver.encrypt(...); or doing it in PHP like if($usePyPgp)
$this->include_script('driver.pypgphttpd.js');
else
$this->include_script('driver.openpgpjs.js'); and keep using invocations of encrypt() etc. just like they're currently done? |
Yes. There shalt be no crypto in PHP :-) |
We'll probably still have to use some PHP to let the JavaScript code know which option the user chose in the preferences, so it doesn't make much difference IMHO... but I agree that it would be cleaner to do the actual differentiation in JS. |
Yes, the setting should be PHP based. And then for differentiation we could just echo a JS var declaration from PHP.
Yes, please. Basically rc_openpgp.crypto.js and rc_openpgp.js, if you have time for it. Once finished I can throw out the driver for pygpghttpd farily quickly, the backend etc is already done.
None |
Abstract the crypto parts and make OpenPGP.js a separate driver as preparation for multiple driver support (#64).
The text was updated successfully, but these errors were encountered: