Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --certificate flag #64

Merged
merged 9 commits into from
Sep 2, 2021
Merged

Implement --certificate flag #64

merged 9 commits into from
Sep 2, 2021

Conversation

niklashigi
Copy link
Owner

I'm opening this PR to make a few changes to #63 before merging.

@maormagori
Copy link
Contributor

May I suggest, in apply-patches.ts I conditionally added the task of copying the PEM file. A better solution for this, in hindsight, is making this task a skippable one based on the value of certificatePath.

@niklashigi
Copy link
Owner Author

@maormagori Good point, don't know why I didn't think of changing that when reading through your code. I changed it now! 👍

@niklashigi niklashigi changed the title Implement --certificate flag (based on #63) Implement --certificate flag Sep 2, 2021
@niklashigi niklashigi merged commit 035cb1b into main Sep 2, 2021
@niklashigi niklashigi deleted the certificate-flag branch September 2, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants