Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDR Videos do not get extra brightness applied #28

Closed
SUPERCELLEX opened this issue Jul 30, 2023 · 5 comments · Fixed by #30
Closed

SDR Videos do not get extra brightness applied #28

SUPERCELLEX opened this issue Jul 30, 2023 · 5 comments · Fixed by #30
Labels
bug Something isn't working

Comments

@SUPERCELLEX
Copy link
Contributor

When watching a video with BrightIntosh enabled, the video will have SDR brightness unless the mouse cursor is moving, this occurs in Apple apps like Safari and QuickTIme, other apps like VLC, Chromium and FireFox are not affected. This appears to be a quirk about how Apple things specifically handles color profiles that fights with BrightIntosh.

@SUPERCELLEX
Copy link
Contributor Author

Debugging, it seems HDR videos don't either, on all apps, including non-Apple ones. It seems the Apple behavior between HDR and SDR doesn't change, so Apple software still engages the HDR anti-clip on SDR content
It seems to fix this you'd need to find a way to kill the HDR anti-clip, either only on SDR or just by telling the user not to watch HDR with BrightIntosh enabled unless you want videos clipping.

@niklasr22
Copy link
Owner

Thanks for the detailed check! I think increasing the brightness of SDR videos makes sense, but I am not sure about HDR videos yet. That clipping destroys the experience...

(Issues can be tagged with #x whereas x is the corresponding "id"😉)

@niklasr22
Copy link
Owner

niklasr22 commented Jul 30, 2023

May be related to #4

(Same compositingFilter behaviour for mission control)

@SUPERCELLEX
Copy link
Contributor Author

The funny thing is, the system works close to flawlessly now on everything BUT Apple-vendored apps, so on Chrome HDR will not clip and SDR's brightness is managed properly, but on Safari everything is broken

@SUPERCELLEX
Copy link
Contributor Author

Moving the mouse on an HDR video WILL clip it, on both non-Apple and Apple apps, however with Chromium and Firefox SDR does not exhibit this seemingly anti-clip calibration on Chrome/Firefox
In this sense Apple is actually doing it more correct by enforcing that SDR stays with SDR's display properties, but it breaks apps like BrightIntosh in doing so
Also I meant like labeling bug vs feature, I'm not good at GitHub tbh

@niklasr22 niklasr22 added the bug Something isn't working label Jul 31, 2023
@niklasr22 niklasr22 linked a pull request Aug 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants