Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element with style 'overflow: hidden auto' will fail rendering #1850

Closed
2 tasks done
daniel-hauser opened this issue May 26, 2019 · 1 comment · Fixed by #1851
Closed
2 tasks done

Element with style 'overflow: hidden auto' will fail rendering #1850

daniel-hauser opened this issue May 26, 2019 · 1 comment · Fixed by #1851

Comments

@daniel-hauser
Copy link

daniel-hauser commented May 26, 2019 •
edited
Loading

  • You are using the latest version
  • You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:

Trying to export an element with style overflow: hidden auto

v1.0.0-rc.0: works as expected see here.
v1.0.0-rc.1: will fail with Error parsing CSS component value, multiple values found when expecting only one see here.

Specifications:

  • html2canvas version tested with:
    • Browser & version: Google Chrome Version 74.0.3729.157 (Official Build) (64-bit)
    • Operating system: MacOS Mojave 10.14.5
@daniel-hauser daniel-hauser changed the title Element with style overflow: hidden auto will fail Element with style 'overflow: hidden auto' will fail May 26, 2019
@daniel-hauser daniel-hauser changed the title Element with style 'overflow: hidden auto' will fail Element with style 'overflow: hidden auto' will fail rendering May 26, 2019
niklasvh added a commit that referenced this issue May 26, 2019
@niklasvh
fix: multi token overflow #1850
c9346ca
@niklasvh niklasvh mentioned this issue May 26, 2019
Merged
niklasvh added a commit that referenced this issue May 26, 2019
@niklasvh
fix: multi token overflow #1850 (#1851)
409674f
@niklasvh
Copy link
Owner

Thanks for providing everything necessary to replicate the issue, I have a fix in #1851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: multi token overflow niklasvh/html2canvas
2 participants
@niklasvh @daniel-hauser