Skip to content

chore(linter): fix hadolint warnings #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(linter): fix hadolint warnings #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/alpine.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ FROM python:{{ python_image }} AS builder
# Install node prereqs, nodejs and yarn
# Ref: https://raw.githubusercontent.com/nodejs/docker-node/master/Dockerfile-alpine.template
# Ref: https://yarnpkg.com/en/docs/install
RUN apk add curl
RUN apk add --no-cache curl && rm /var/cache/apk/*
# FIXME: no arm + musl build yet
# Ref: https://github.com/nodejs/unofficial-builds/pull/59
# Ref: https://github.com/nodejs/node/pull/45756
Expand All @@ -19,10 +19,10 @@ FROM python:{{ python_image }}
LABEL org.opencontainers.image.authors="Nikolai R Kristiansen <nikolaik@gmail.com>"

RUN addgroup -g 1000 pn && adduser -u 1000 -G pn -s /bin/sh -D pn
RUN apk add libstdc++
RUN apk add --no-cache libstdc++ && rm /var/cache/apk/*
COPY --from=builder /node-v{{ nodejs_canonical }}-linux-x64-musl /usr/local
RUN corepack enable yarn
RUN pip install -U pip pipenv uv
RUN pip install --no-cache-dir -U pip pipenv uv

# Poetry
# Mimic what https://install.python-poetry.org does without the flexibility (platforms, install sources, etc).
Expand Down
4 changes: 2 additions & 2 deletions templates/debian.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ RUN groupadd --gid 1000 pn && useradd --uid 1000 --gid pn --shell /bin/bash --cr
ENV POETRY_HOME=/usr/local

RUN \
{% if distro_variant == "slim" %} apt-get update && apt-get install curl gnupg2 xz-utils -yqq && \
{% if distro_variant == "slim" %} apt-get update && apt-get install --no-install-recommends curl gnupg2 xz-utils -yqq && \
{% endif %} apt-get upgrade -yqq && \
rm -rf /var/lib/apt/lists/*
RUN NODE_VERSION="v{{ nodejs_canonical }}" \
Expand All @@ -31,5 +31,5 @@ RUN NODE_VERSION="v{{ nodejs_canonical }}" \
&& ln -s /usr/local/bin/node /usr/local/bin/nodejs
RUN corepack enable yarn

RUN pip install -U pip pipenv uv && \
RUN pip install --no-cache-dir -U pip pipenv uv && \
curl -fsSL --compressed https://install.python-poetry.org | python -