Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluateSteps after each submodule #5

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

fwereade
Copy link

@fwereade fwereade commented Apr 1, 2024

Description

  • does post-submodule evaluation after each submodule, to handle indirect dependencies (with test)
  • bases re-evaluation decision on whether input state has changed (because output state is handled by the above)
  • no longer double-counts the initial evaluateSteps and expandBlockses in parseDuration

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@@ -163,9 +161,6 @@ func (e *evaluator) EvaluateAll(ctx context.Context) (terraform.Modules, map[str

e.debug.Log("Finished processing %d submodule(s).", len(modules))

e.debug.Log("Starting post-submodule evaluation...")
e.evaluateSteps()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to do the evaluation after expanding the blocks and evaluating the submodules (See the failed test).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…ah, dammit, yes – sometimes there are no submodules

@nikpivkin nikpivkin merged commit 58efb65 into nikpivkin:tf-eval-submodules Apr 2, 2024
11 checks passed
@nikpivkin
Copy link
Owner

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants