upgrade to depend on module antlr/v4

[juliandanciu]

This updates the go module to depend on the v4 version of the antlr module.

go test ./... passes

Relevant antlr commits:

antlr/antlr4@69fdc2f
antlr/antlr4@b9d975a

[juliandanciu]

👋🏼 Hello @nikunjy. Would you be able to review this pull request? I'm having some problems because antlr broke compatibility without updating major versions earlier.

[nikunjy]

I upgraded version of golang. the workflow was failing with your changes but now it should pass.

Rebasing and running the tests.

[juliandanciu]

@nikunjy Thanks!

If you are bumping the major version, does that mean the module path will need to change in go.mod?
module github.com/nikunjy/rules/v2 ?

[nikunjy]

Yes I think you are right. I don’t know if functionally there is a change but because we have made major upgrades. We should change it to v2 I can do a PR soon. If you wanna do it, feel free to do so.

…

On Mon, Sep 19, 2022 at 11:22 PM Julian Danciu ***@***.***> wrote: @nikunjy <https://github.com/nikunjy> Thanks! If you are bumping the major version, does that mean the module path will need to change in go.mod? module github.com/nikunjy/rules/v2 ? — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDSYNEDXTOIMFZNGEH5XJ3V7FJ3TANCNFSM6AAAAAAQNOG3LE> . You are receiving this because you were mentioned.Message ID: ***@***.***>