ComboBox changes, created its own GwtWidgetFinder.

[branflake2267]

See what you think of this...

1. creates its own gwt widget finder
2. added a search with out using a with

[branflake2267]

changed the search, so no with has to be used

[niloc132]

The basic problem I have with this is that it just finds the first ComboBox in the dom, not necessarily the first one the user sees. Could be invisible (not totally sure of this) could be on the main page (i.e. when the user is in a modal window - technically the one on the main page will come first), or they could be reordered on the page.

Helpful for testing individual components, but less good for describing the relationship of the elements in a full application.

If we were to go this route, I'd want to make it configurable globally, and off by default, to avoid possible confusion. Or, since the point here is to just find the first thing that matches, a GwtWidget.findFirst(Class<T extends GwtWidget) that returns T rather than a finder<T>. That could key off of @ForWidget and find the first (visible?) instance in the dom.

[branflake2267]

I don't mind which way you want to go. I tried searching for the combo by field in its latest config and it doesn't find it, so I thought I'd see what you thought. I think the last else should probably just say use a with* in the builder, otherwise it seems that I can't find a widget at all, and no such element is found, but maybe its operator error.

I was picturing something like this:
ComboBox combo = myFormWithOneCombo.find(ComboBox.class, driver).done();

[branflake2267]

Just a thought,

List<ComboBox> combo = window.findWidgets(ComboBox.class, driver).done();