Removing strict check on id properties

nilportugues · Oct 2, 2015 · 0cdb9e1 · 0cdb9e1
1 parent e52a4b2
commit 0cdb9e1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/src/Mapping/MappingFactory.php b/src/Mapping/MappingFactory.php
@@ -95,19 +95,12 @@ private static function getSelfUrl(array &$mappedClass)
     /**
      * @param array $mappedClass
      *
-     * @throws MappingException
-     *
      * @return mixed
      */
     private static function getIdProperties(array &$mappedClass)
     {
-        if (empty($mappedClass['id_properties'])) {
-            throw new MappingException(
-                'Could not find "id_properties" property with data . This is required in order to make the resource to be reachable.'
-            );
-        }
 
-        return $mappedClass['id_properties'];
+        return (!empty($mappedClass['id_properties']))? $mappedClass['id_properties'] : [];
     }
 
     /**

diff --git a/tests/Mapping/MappingFactoryTest.php b/tests/Mapping/MappingFactoryTest.php
@@ -61,12 +61,6 @@ public function testItWillThrowExceptionIfArrayHasNoClassKey()
         MappingFactory::fromArray($mappedClass);
     }
 
-    public function testItWillThrowExceptionIfArrayHasNoIdPropertiesKey()
-    {
-        $this->setExpectedException(MappingException::class);
-        $mappedClass = ['class' => 'Post', 'id_properties' => [], 'urls' => ['self' => 'some/url']];
-        MappingFactory::fromArray($mappedClass);
-    }
 
     public function testItWillThrowExceptionIfArrayHasNoSelfUrlKey()
     {