Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Don't use deprecated exception messsage property #120

Merged

Conversation

meliache
Copy link
Collaborator

That property is deprecated since python 2.6, see PEP-352 1.

Solves #119

That property is deprecated since python 2.6, see PEP-352 [1].

Solves issue #119 [2].

[1]: https://www.python.org/dev/peps/pep-0352/#retracted-ideas
[2]: #119
@meliache meliache added the bug Something isn't working label Jul 30, 2021
@meliache meliache self-assigned this Jul 30, 2021
@meliache meliache linked an issue Jul 30, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #120 (7169e01) into main (31fe325) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   56.58%   56.72%   +0.13%     
==========================================
  Files          23       23              
  Lines        1495     1495              
==========================================
+ Hits          846      848       +2     
+ Misses        649      647       -2     
Impacted Files Coverage Δ
b2luigi/core/utils.py 73.15% <ø> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fe325...7169e01. Read the comment docs.

@meliache meliache merged commit e0b74d3 into main Aug 3, 2021
@meliache meliache deleted the bugfix/do-not-use-deprecated-exception-message-property branch August 3, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated message property for exceptions is used
2 participants