Allow for gbasf2 projects with multiple output sub<xy> directories
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that, the assumption was that all outputs are saved in a final sub00 directory. But from gbasf2 release v5r1p3 to be released on 2021-09-16, jobs with many outputs (> 1000) can have outputs in additional subxy directories. This means that when downloading, we will also get multiple sub<xy> directories in the download. However, currently, the b2luigi user expects that all downloaded file names will be in a common directory, so after a completed download, we move the contents of all sub* directories into the final output directory. We can then still cross-check that the download was complete by replace sub<xy> with a wildcard when doing the remote gb2_ds_list command See #80
meliache
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 56.89% 56.73% -0.17%
==========================================
Files 23 23
Lines 1494 1500 +6
==========================================
+ Hits 850 851 +1
- Misses 644 649 +5
Continue to review full report at Codecov.
|
Instead of "/*/" for matching different sub<xy> directories, use "/sub*/", to prevent other subdirectories from being matched (even if that should never happen, better safe than sorry)
meliache
deleted the
feature/allow-for-gbasf2-jobs-with-multiple-output-subs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that, the assumption was that all outputs are saved in a final
sub00directory. But in future releases, jobs with many outputs (> 1000) can have outputs in additionalsub<XY>directories.This means that when downloading, we will also get multiple
sub<XY>directories in the temporary download directory. However, currently, the b2luigi user expects that all downloaded file names will be in a common directory. Therefore, after the completed download, we move the contents of allsub*directories into the final output directory.We can then still do the file-comparison cross-check that the download was complete by replace
sub<XY>`` with a wildcard when doing the remotegb2_ds_list` command.So far I just tested that the wildcards work for
g2_ds_getandgb2_ds_list, but before merging I will run a complete gbasf2 task with this branch and see that everything still works.Resolves #80