Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/migrate pre commit config and update hooks #176

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

meliache
Copy link
Collaborator

@meliache meliache commented Nov 7, 2022

Update pre-commit hooks. Most notably for the developers, updated the flake8 syntax and style-checker to version 5.0.4, which might change slightly what style is accepted. This should also fix an issue with the old flake8 version not being compatible with the latest version of importlib_meta, which caused the pre-commit flake8 hook in the github actions to fail. In the process also migrated the pre-commit config format to the new layout.

Update `pre-commit` hooks. Most notably for the developers, update the `flake8`
syntax and style-checker to version 5.0.4, which might change slightly what
style is accepted. This should also fix [an
issue](python/importlib_metadata#406) with the old
flake8 version not being compatible with the latest version of `importlib_meta`,
which the pre-commit flake8 hook in the github actions to fail. In the process
also migrated the pre-commit config format to the new layout.
@meliache meliache added the bug Something isn't working label Nov 7, 2022
@meliache meliache self-assigned this Nov 7, 2022
@meliache meliache mentioned this pull request Nov 7, 2022
@meliache meliache merged commit 50045e2 into main Nov 7, 2022
@meliache meliache deleted the feature/migrate-pre-commit-config-and-update-hooks branch November 7, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0.0 fails with flake8
1 participant