Merge pull request #4338 from corentin-soriano/fix_fav_remove_issue

Fix favorites remove issue.
nilsteampassnet · Sep 20, 2024 · 61d529b · 61d529b
2 parents dbd5b58 + 6fb779e
commit 61d529b
Showing 1 changed file with 2 additions and 13 deletions.
diff --git a/sources/favourites.queries.php b/sources/favourites.queries.php
@@ -104,19 +104,8 @@
             //Get actual favourites
             $data = DB::queryfirstrow('SELECT favourites FROM '.prefixTable('users').' WHERE id = %i', $session->get('user-id'));
             $tmp = explode(';', $data['favourites']);
-            $favorites = '';
-            $arrayFavorites = array();
-            //redefine new list of favourites
-            foreach ($tmp as $favorite) {
-                if (!empty($favorite) && $favorite != $post_id) {
-                    if (empty($favorites)) {
-                        $favorites = $favorite;
-                    } else {
-                        $favorites = ';'.$favorite;
-                    }
-                    array_push($arrayFavorites, $favorite);
-                }
-            }
+            $arrayFavorites = array_diff($tmp, [$post_id]);
+
             //update user's account
             DB::update(
                 prefixTable('users'),