Completes the implementation of the encryptClientServer parameter . #4337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very useful to be able to disable client/server communication encryption for debugging or using an application firewall.
The
encryptClientServer
parameter was already present in thetp.config.php
, and the JavaScript part was already prepared.It should be noted that the encryption seems unnecessary since it is symmetric, and the key is present throughout all communications:
During my tests I noticed that the stripHtml function is vulnerable to XSS injection since it creates unsafe elements in the DOM.
As there was no consistency in using it, I removed its call and definition.