Skip to content

Commit

Permalink
fix #13731, ambiguous repr of pointers (#13732)
Browse files Browse the repository at this point in the history
  • Loading branch information
narimiran authored Mar 23, 2020
1 parent fc5dd11 commit 4fb7f07
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions lib/system/repr_v2.nim
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ proc repr*[Enum: enum](x: Enum): string {.magic: "EnumToStr", noSideEffect.}

proc repr*(p: pointer): string =
## repr of pointer as its hexadecimal value
if p == nil:
if p == nil:
result = "nil"
else:
when nimvm:
Expand All @@ -66,7 +66,7 @@ template repr*(x: distinct): string =

template repr*(t: typedesc): string = $t

proc reprObject[T: tuple|object](res: var string, x: T) =
proc reprObject[T: tuple|object](res: var string, x: T) =
res.add '('
var firstElement = true
const isNamed = T is object or isNamedTuple(T)
Expand Down Expand Up @@ -98,10 +98,6 @@ proc repr*[T: tuple|object](x: T): string =
when T is object:
result = $typeof(x)
reprObject(result, x)

proc repr*[T](x: ptr T): string =
result.add repr(pointer(x)) & " "
result.add repr(x[])

proc repr*[T](x: ref T | ptr T): string =
if isNil(x): return "nil"
Expand Down

0 comments on commit 4fb7f07

Please sign in to comment.