trigger valgrind failure on memory leak

testament/specs.nim

@@ -43,7 +43,7 @@ type
     reFilesDiffer,      # expected and given filenames differ
     reLinesDiffer,      # expected and given line numbers differ
     reOutputsDiffer,
-    reExitcodesDiffer,
+    reExitcodesDiffer,  # exit codes of program or of valgrind differ
     reTimeout,
     reInvalidPeg,
     reCodegenFailure,

testament/testament.nim

@@ -502,7 +502,7 @@ proc testSpecHelper(r: var TResults, test: var TTest, expected: TSpec,
           else:
             exeCmd = exeFile.dup(normalizeExe)
             if expected.useValgrind:
-              args = @["--error-exitcode=1"] & exeCmd & args
+              args = @["--error-exitcode=1", "--leak-check=yes"] & exeCmd & args
               exeCmd = "valgrind"
           var (_, buf, exitCode) = execCmdEx2(exeCmd, args, input = expected.input)
           # Treat all failure codes from nodejs as 1. Older versions of nodejs used

testament/tests/shouldfail/tvalgrind.nim

@@ -0,0 +1,7 @@
+discard """
+valgrind: true
+cmd: "nim $target --gc:arc -d:useMalloc $options $file"
+"""
+
+# test that a memory leak is caught by valgrind
+discard alloc(1)

tests/testament/tshould_not_work.nim

@@ -29,6 +29,8 @@ FAIL: tests/shouldfail/tsortoutput.nim C
 Failure: reOutputsDiffer
 FAIL: tests/shouldfail/ttimeout.nim C
 Failure: reTimeout
+FAIL: tests/shouldfail/tvalgrind.nim C
+Failure: reExitcodesDiffer
 '''
 """
 

tests/valgrind/tleak_arc_no_malloc.nim

@@ -0,0 +1,9 @@
+discard """
+valgrind: true
+cmd: "nim $target --gc:arc $options $file"
+exitcode: 0
+"""
+
+# unlike tleak_arc_useMalloc.nim, tleak_arc_noUseMalloc.nim is powerless to
+# detect the memory leak because malloc is not used
+discard alloc(1)

tests/valgrind/tleak_arc_useMalloc.nim

@@ -0,0 +1,9 @@
+discard """
+valgrind: true
+cmd: "nim $target --gc:arc -d:useMalloc $options $file"
+exitcode: 1
+outputsub: "   definitely lost: 7 bytes in 2 blocks"
+"""
+
+discard alloc(3)
+discard alloc(4)

tests/valgrind/tleak_orc_no_malloc.nim

@@ -0,0 +1,9 @@
+discard """
+valgrind: true
+cmd: "nim $target --gc:orc $options $file"
+exitcode: 0
+"""
+
+# unlike tleak_orc_useMalloc.nim, tleak_orc_noUseMalloc.nim is powerless to
+# detect the memory leak because malloc is not used
+discard alloc(1)

tests/valgrind/tleak_orc_useMalloc.nim

@@ -0,0 +1,9 @@
+discard """
+valgrind: true
+cmd: "nim $target --gc:orc -d:useMalloc $options $file"
+exitcode: 1
+outputsub: "   definitely lost: 7 bytes in 2 blocks"
+"""
+
+discard alloc(3)
+discard alloc(4)

tests/valgrind/tleak_refc.nim

@@ -0,0 +1,8 @@
+discard """
+valgrind: true
+cmd: "nim $target --gc:refc -d:useMalloc $options $file"
+exitcode: 0
+"""
+
+# Valgrind cannot detect this leak even if malloc is used because --gc:refc
+discard alloc(1)