Skip to content

Commit

Permalink
Fix #13633
Browse files Browse the repository at this point in the history
  • Loading branch information
@Clyybber
Clyybber committed Mar 12, 2020
1 parent bbc231f commit d84c4bb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion compiler/extccomp.nim
View file
Original file line number Diff line number Diff line change
Expand Up @@ -998,10 +998,11 @@ proc writeJsonBuildInstructions*(conf: ConfigRef) =
f.write escapeJson(x)

proc cfiles(conf: ConfigRef; f: File; buf: var string; clist: CfileList, isExternal: bool) =
var comma = false
for i, it in clist:
if CfileFlag.Cached in it.flags: continue
let compileCmd = getCompileCFileCmd(conf, it)
if i > 0: lit ",\L"
if comma: lit ",\L"; comma = false
lit "["
str it.cname.string
lit ", "
Expand Down

3 comments on commit d84c4bb

@Clyybber
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidently pushed this to devel directly :/

@timotheecour
Copy link
Member

@timotheecour timotheecour commented on d84c4bb Mar 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i just had a fix for this! see #13635 ;
please go through PR's each time instead of directly pushing; it's much better to track / comment on / see CI, individual commits etc; I'll update my PR to rebase

@Clyybber
Copy link
Contributor Author

@Clyybber Clyybber commented on d84c4bb Mar 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I intended to do a PR, but I fell into the git branch fix#13633 does not imply git checkout fix#13633 trap
git checkout -b should save me from that in the future...

Please sign in to comment.