Macros and zero-argument custom pragmas can't be defined on the same proc #10994

dawkot · 2019-04-10T00:07:11Z

import macros

macro foo(x): untyped = x
template bar {.pragma.}

proc a {.bar.} = discard # works
proc b {.bar, foo.} = discard # doesn't

metagn · 2022-01-03T17:00:09Z

This code works now, unless I am missing something? How did this not work in the first place?

ringabout · 2022-01-03T17:06:27Z

How did this not work in the first place?

It didn't work before 1.0.2: /usercode/in.nim(7, 10) Error: invalid pragma: bar

* New/better macro pragmas, make some experimental fix #15920, close #18212, close #14781, close #6696, close nim-lang/RFCs#220 Variable macro pragmas have been changed to only take a unary section node. They can now also be applied in sections with multiple variables, as well as `const` sections. They also accept arguments. Templates now support macro pragmas, mirroring other routine types. Type and variable macro pragmas have been made experimental. Symbols without parentheses instatiating nullary macros or templates has also been documented in the experimental manual. A check for a redefinition error based on the left hand side of variable definitions when using variable macro pragmas was disabled. This nerfs `byaddr` specifically, however this has been documented as a consequence of the experimental features `byaddr` uses. Given how simple these changes are I'm worried if I'm missing something. * accomodate compiler boot * allow weird pragmas * add test for #10994 * remove some control flow, try remove some logic

* New/better macro pragmas, make some experimental fix nim-lang#15920, close nim-lang#18212, close nim-lang#14781, close nim-lang#6696, close nim-lang/RFCs#220 Variable macro pragmas have been changed to only take a unary section node. They can now also be applied in sections with multiple variables, as well as `const` sections. They also accept arguments. Templates now support macro pragmas, mirroring other routine types. Type and variable macro pragmas have been made experimental. Symbols without parentheses instatiating nullary macros or templates has also been documented in the experimental manual. A check for a redefinition error based on the left hand side of variable definitions when using variable macro pragmas was disabled. This nerfs `byaddr` specifically, however this has been documented as a consequence of the experimental features `byaddr` uses. Given how simple these changes are I'm worried if I'm missing something. * accomodate compiler boot * allow weird pragmas * add test for nim-lang#10994 * remove some control flow, try remove some logic

mratsim added Macros Pragmas labels Apr 10, 2019

ringabout added the works_but_needs_test_case label Jan 3, 2022

metagn added a commit to metagn/Nim that referenced this issue Jan 17, 2022

add test for nim-lang#10994

73f4d27

metagn mentioned this issue Jan 17, 2022

New/better macro pragmas, mark some as experimental #19406

Merged

Araq closed this as completed in #19406 Jan 20, 2022

ringabout removed the works_but_needs_test_case label Jun 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Macros and zero-argument custom pragmas can't be defined on the same proc #10994

Macros and zero-argument custom pragmas can't be defined on the same proc #10994

dawkot commented Apr 10, 2019

metagn commented Jan 3, 2022

ringabout commented Jan 3, 2022

Macros and zero-argument custom pragmas can't be defined on the same proc #10994

Macros and zero-argument custom pragmas can't be defined on the same proc #10994

Comments

dawkot commented Apr 10, 2019

metagn commented Jan 3, 2022

ringabout commented Jan 3, 2022