strutils.addf chokes on: ret.addf "foo $1 bar" % ["$"]

[timotheecour]

strutils.addf chokes on: ret.addf "foo $1 bar" % ["$"]

Example

var ret: string
ret.addf "foo $1 bar" % ["$"]

Current Output

/Users/timothee/git_clone/nim/timn/tests/nim/all/t10851.nim(7) t10851
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/strutils.nim(2753) addf
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/strutils.nim(2693) invalidFormatString
Error: unhandled exception: invalid format string [ValueError]

Expected Output

works

Possible Solution

• TBD

Additional Information

• root cause of nim doc .. fails when runnableExamples uses $ [devel] [regression] #14485

nim e013ebc91a22eeccc9546498994b0c561e438599 1.3.5

[timotheecour]

my bad, % should not be used with addf (unless you want that effect):

when true:
  import strutils
  var ret: string
  # ret.addf "foo $1 bar" % ["$"] # bad
  ret.addf "foo $1 bar", ["$"] # good
  doAssert ret == "foo $ bar"