fix #14485 #14487
Merged
fix #14485 #14487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_fix_14485_addf_bug_workaround
branch
from
d168370 to
bf3abbb
Compare
|
@timotheecour Thanks for this hot fix! I confirm that the fix works. |
|
This PR LGTM; you can merge it. |
timotheecour
changed the title
|
Just to clarify, I have tested your correct fix commit bdd8853 and it LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14485
%should not be used with addf...add test
verified by running
./koch docslocally