Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csources generation broken after #16764 #17078

Closed
alaviss opened this issue Feb 17, 2021 · 2 comments · Fixed by #17079
Closed

csources generation broken after #16764 #17078

alaviss opened this issue Feb 17, 2021 · 2 comments · Fixed by #17079

Comments

@alaviss
Copy link
Collaborator

alaviss commented Feb 17, 2021

Demonstrated by nightlies

Build log

Full log at: https://github.com/nim-lang/nightlies/pull/51/checks?check_run_id=1922863521#step:11:284

nim compile -f --symbolfiles:off --compileonly --gen_mapping --cc:gcc --skipUserCfg --os:solaris --cpu:i386 -d:danger -d:gitHash:4c568734f426052a43693772cf12301d7b457060 compiler/nim.nim
Hint: used config file '/home/runner/work/nightlies/nightlies/nim/config/nim.cfg' [Conf]
Hint: used config file '/home/runner/work/nightlies/nightlies/nim/config/config.nims' [Conf]
Hint: used config file '/home/runner/work/nightlies/nightlies/nim/compiler/nim.cfg' [Conf]
.............................................
/home/runner/work/nightlies/nightlies/nim/lib/pure/concurrency/cpuinfo.nim(100, 14) Error: undeclared identifier: 'sysconf'
Error: call to nim compiler failed
Error: execution of an external program failed: '/home/runner/work/nightlies/nightlies/nim/tools/niminst/niminst --var:version=1.5.1 --var:mingw=none csource --main:compiler/nim.nim compiler/installer.ini -d:danger -d:gitHash:4c568734f426052a43693772cf12301d7b457060'
FAILURE

Commit 4c56873

Caused by 31bb67a#diff-3951d345226b809e9d95884f6c5d550de903ce8113e6f971115483ba1872dde0L18

@alaviss
Copy link
Collaborator Author

alaviss commented Feb 17, 2021

@timotheecour

@timotheecour
Copy link
Member

timotheecour commented Feb 18, 2021

@alaviss thanks for the ping, see #17079

  • I can run locally nim compile -f --symbolfiles:off --compileonly --gen_mapping --cc:gcc --skipUserCfg --os:solaris --cpu:i386 -d:danger -d:gitHash:4c568734f426052a43693772cf12301d7b457060 compiler/nim.nim but how can I run this more generally to ensure nightlies passes?

  • more generally (refs run nightlies (or a subset) in CI to avoid regressions timotheecour/Nim#594), can we add something to nim's CI so that it runs, if not all what nightlies runs, at least a representative subset to catch as many regressions as possible before a merge? what's the command to run nigthtlies, and how long does it take to run in nightlies' CI?

refs timotheecour#610

Araq pushed a commit that referenced this issue Feb 18, 2021
* fix #17078 csources generation

* fixup
ardek66 pushed a commit to ardek66/Nim that referenced this issue Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants