Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json.% raises Defect for uint64 #17383

Closed
arnetheduck opened this issue Mar 15, 2021 · 1 comment · Fixed by #17389
Closed

json.% raises Defect for uint64 #17383

arnetheduck opened this issue Mar 15, 2021 · 1 comment · Fixed by #17389

Comments

@arnetheduck
Copy link
Contributor

Nim/lib/pure/json.nim

Line 315 in 51a04a3

result = JsonNode(kind: JInt, num: BiggestInt(n))

converting a uint64 to a JsonNode raises a Defect on values outside the BiggestInt range, defeating the purpose of using this overload to begin with - to resolve, one would either deprecate / remove the overload or output a string instead - the latter would require parsing strings as well in the opposite direction.
@arnetheduck arnetheduck mentioned this issue Mar 15, 2021
Merged
timotheecour added a commit to timotheecour/Nim that referenced this issue Mar 15, 2021
@timotheecour
fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works…
a101137 
… with uint|uint64
@timotheecour timotheecour mentioned this issue Mar 15, 2021
Merged
timotheecour added a commit to timotheecour/Nim that referenced this issue Mar 15, 2021
@timotheecour
fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works…
9e8773e 
… with uint|uint64
timotheecour added a commit to timotheecour/Nim that referenced this issue Mar 15, 2021
@timotheecour
fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works…
f2b84db 
… with uint|uint64
@timotheecour
Copy link
Member

see #17389

timotheecour added a commit to timotheecour/Nim that referenced this issue Mar 16, 2021
@timotheecour
fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works…
f284cbb 
… with uint|uint64
Araq pushed a commit that referenced this issue Mar 16, 2021
@timotheecour
fix #17383: json.%,to and jsonutils.formJson,toJson now works with ui…
895a40d 
…nt|uint64 (#17389) [backport:1.2]

* fix #17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64
* fixup
* fix for js
narimiran pushed a commit that referenced this issue Mar 18, 2021
@timotheecour @narimiran
fix #17383: json.%,to and jsonutils.formJson,toJson now works with ui…
e013183 
…nt|uint64 (#17389) [backport:1.2]

* fix #17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64
* fixup
* fix for js

(cherry picked from commit 895a40d)
@arnetheduck arnetheduck mentioned this issue Mar 18, 2021
Closed
narimiran pushed a commit that referenced this issue Mar 18, 2021
@timotheecour @narimiran
fix #17383: json.%,to and jsonutils.formJson,toJson now works with ui…
f6885c9 
…nt|uint64 (#17389) [backport:1.2]

* fix #17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64
* fixup
* fix for js

(cherry picked from commit 895a40d)
narimiran pushed a commit that referenced this issue Mar 19, 2021
@timotheecour @narimiran
fix #17383: json.%,to and jsonutils.formJson,toJson now works with ui…
e5027dc 
…nt|uint64 (#17389) [backport:1.2]

* fix #17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64
* fixup
* fix for js

(cherry picked from commit 895a40d)
ringabout pushed a commit to ringabout/Nim that referenced this issue Mar 22, 2021
@timotheecour @ringabout
fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works…
97f4736 
… with uint|uint64 (nim-lang#17389) [backport:1.2]

* fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64
* fixup
* fix for js
ardek66 pushed a commit to ardek66/Nim that referenced this issue Mar 26, 2021
@timotheecour @ardek66
fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works…
7313b42 
… with uint|uint64 (nim-lang#17389) [backport:1.2]

* fix nim-lang#17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64
* fixup
* fix for js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #17383: json.%,to and jsonutils.formJson,toJson now works with uint|uint64 timotheecour/Nim
2 participants
@arnetheduck @timotheecour