regression that `std/json` `seq[JsonNode]` `==` operator raises exception only in Nim 2.0+ #22254

tersec · 2023-07-11T08:34:03Z

Description

import std/json
proc f(a, b: seq[JsonNode]) {.raises: [].} = discard a == b

Nim Version

Nim Compiler Version 1.6.14 [Linux: amd64]
Compiled at 2023-06-29
Copyright (c) 2006-2023 by Andreas Rumpf

active boot switches: -d:release

version-2-0:

Nim Compiler Version 1.9.5 [Linux: amd64]
Compiled at 2023-07-11
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: 9ddd768cce291e5c562cde23baeeefb47aa79c86
active boot switches: -d:release

devel:

Nim Compiler Version 1.9.5 [Linux: amd64]
Compiled at 2023-07-11
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: 9ddd768cce291e5c562cde23baeeefb47aa79c86
active boot switches: -d:release

Current Output

1.6.14: compiles
2.0/devel: Error: a == b can raise an unlisted exception: Exception

Expected Output

Compiles

Possible Solution

No response

Additional Information

Related to #22253 but distinct in that this behaves differently in 1.6.14 and 2.0/devel, while that one behaves consistently across all of 1.6.14, 2.0, and devel, so some additional distinct mechanism is presumably operating in this case.

The text was updated successfully, but these errors were encountered:

juancarlospaco · 2023-07-11T13:37:14Z

!nim c

import std/json
proc f(a, b: seq[JsonNode]) {.raises: [].} = discard a == b

github-actions · 2023-07-11T15:09:39Z

@juancarlospaco (contributor)

devel :-1: FAIL

Output

Error: Command failed: nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off  --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(2, 56) Error: a == b can raise an unlisted exception: Exception

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:37:40
Finished 2023-07-11T13:37:41
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

IR

AST

nnkStmtList.newTree(
  nnkImportStmt.newTree(
    nnkInfix.newTree(
      newIdentNode("/"),
      newIdentNode("std"),
      newIdentNode("json")
    )
  ),
  nnkProcDef.newTree(
    newIdentNode("f"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newEmptyNode(),
      nnkIdentDefs.newTree(
        newIdentNode("a"),
        newIdentNode("b"),
        nnkBracketExpr.newTree(
          newIdentNode("seq"),
          newIdentNode("JsonNode")
        ),
        newEmptyNode()
      )
    ),
    nnkPragma.newTree(
      nnkExprColonExpr.newTree(
        newIdentNode("raises"),
        nnkBracket.newTree(
        )
      )
    ),
    newEmptyNode(),
    nnkStmtList.newTree(
      nnkDiscardStmt.newTree(
        nnkInfix.newTree(
          newIdentNode("=="),
          newIdentNode("a"),
          newIdentNode("b")
        )
      )
    )
  )
)

stable :+1: OK

Output

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:37:42
Finished 2023-07-11T13:37:43
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

1.6.0 :+1: OK

Output

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:37:45
Finished 2023-07-11T13:37:46
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

1.4.0 :+1: OK

Output

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:37:48
Finished 2023-07-11T13:37:49
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

1.2.0 :+1: OK

Output

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:38:05
Finished 2023-07-11T13:38:05
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

1.0.0 :+1: OK

Output

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:38:19
Finished 2023-07-11T13:38:20
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

0.20.2 :+1: OK

Output

Stats

Created 2023-07-11T13:37:14Z
Started 2023-07-11T13:38:31
Finished 2023-07-11T13:38:32
Duration 1 minute
Commands nim c --run -d:strip -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --threads:off --verbosity:0 --hints:off --warnings:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

#1e15f975b ➡️ 🐛

Diagnostics

ringabout introduced a bug at 2022-10-15 20:07:40 +0800 on commit #1e15f975b with message:

fixes #19162; enable `strictEffects` for v2 (#19380)

* enable stricteffects
* add gcsafe
* fix tests
* use func
* fixes pegs tests
* explicitly mark repr related procs with noSideEffect
* add nimLegacyEffects
* change URL
* fixes docopt
* add `raises: []` to repr
* fixes weave
* fixes nimyaml
* fixes glob
* fixes parsetoml
* Apply suggestions from code review
* Update testament/important_packages.nim
* add legacy:laxEffects

The bug is in the files:

changelog.md
compiler/nim.cfg
compiler/options.nim
compiler/sempass2.nim
config/config.nims
doc/manual.md
lib/pure/pegs.nim
lib/system.nim
lib/system/repr_v2.nim
nimsuggest/sexp.nim
testament/important_packages.nim
tests/closure/tnested.nim
tests/effects/teffects6.nim
tests/effects/tgcsafe.nim
tests/effects/tnosideeffect.nim
tests/stdlib/tpegs.nim

The bug can be in the commits:

(Diagnostics sometimes off-by-one).

🤖 Bug found in 1 minute bisecting 1580 commits at 1336 commits per second.

tersec · 2023-07-12T20:24:15Z

My guess is that it's equivalent to

type
  G = object
    case kind: bool
    of false: discard
    of true:  elems: seq[G]

func `==`(a, b: G): bool =
  case a.kind
  of false: true
  of true: a.elems == b.elems

proc f*(a, b: G) {.raises: [].} = discard a == b

which is a simplified case -- but has the same properties where it regresses from 1.6 to 2.0/devel.

Somewhat to my surprise, it didn't have anything to do with the Table lookup KeyError.

…2294)

…ursive calls (nim-lang#22294)

…2294) (cherry picked from commit 5ed44e1)

This was referenced Jul 11, 2023

use JsonNode.isNil rather than == nil to work around Nim issues status-im/nim-json-rpc#167

Merged

update tested Nim versions status-im/nimbus-eth2#5142

Merged

ringabout self-assigned this Jul 19, 2023

ringabout added a commit that referenced this issue Jul 19, 2023

fixes #22254; fixes #22253; stricteffects bugs on recursive calls

fafc279

ringabout mentioned this issue Jul 19, 2023

fixes #22254; fixes #22253; stricteffects bugs on recursive calls #22294

Merged

Araq closed this as completed in #22294 Jul 19, 2023

Araq pushed a commit that referenced this issue Jul 19, 2023

fixes #22254; fixes #22253; stricteffects bugs on recursive calls (#2…

5ed44e1

…2294)

bung87 pushed a commit to bung87/Nim that referenced this issue Jul 29, 2023

fixes nim-lang#22254; fixes nim-lang#22253; stricteffects bugs on rec…

00d4d91

…ursive calls (nim-lang#22294)

narimiran pushed a commit that referenced this issue Sep 11, 2023

fixes #22254; fixes #22253; stricteffects bugs on recursive calls (#2…

e15abcd

…2294) (cherry picked from commit 5ed44e1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression that `std/json` `seq[JsonNode]` `==` operator raises exception only in Nim 2.0+ #22254

regression that `std/json` `seq[JsonNode]` `==` operator raises exception only in Nim 2.0+ #22254

tersec commented Jul 11, 2023

juancarlospaco commented Jul 11, 2023

github-actions bot commented Jul 11, 2023

Output

Stats

IR

AST

Output

Stats

Output

Stats

Output

Stats

Output

Stats

Output

Stats

Output

Stats

Diagnostics

tersec commented Jul 12, 2023

regression that std/json seq[JsonNode] == operator raises exception only in Nim 2.0+ #22254

regression that std/json seq[JsonNode] == operator raises exception only in Nim 2.0+ #22254

Comments

tersec commented Jul 11, 2023

Description

Nim Version

Current Output

Expected Output

Possible Solution

Additional Information

juancarlospaco commented Jul 11, 2023

github-actions bot commented Jul 11, 2023

Output

Stats

IR

AST

Output

Stats

Output

Stats

Output

Stats

Output

Stats

Output

Stats

Output

Stats

Diagnostics

tersec commented Jul 12, 2023

regression that `std/json` `seq[JsonNode]` `==` operator raises exception only in Nim 2.0+ #22254

regression that `std/json` `seq[JsonNode]` `==` operator raises exception only in Nim 2.0+ #22254