Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression from v2.0.10 to 2.2/devel in const with cstring/string literal conversion: context: n.nim(2, 21) Error: type mismatch: got 'cstring' for '""' but expected 'string' #24295

Closed
tersec opened this issue Oct 13, 2024 · 3 comments · Fixed by #24298
Closed

Regression from v2.0.10 to 2.2/devel in const with cstring/string literal conversion: context: n.nim(2, 21) Error: type mismatch: got 'cstring' for '""' but expected 'string' #24295

tersec opened this issue Oct 13, 2024 · 3 comments · Fixed by #24298

Comments

@tersec
Copy link
Contributor

tersec commented Oct 13, 2024

Description

template g(_: int): string = ""
const c: cstring = 0.g()

Nim Version

Builds:

Nim Compiler Version 2.0.10 [Linux: amd64]
Compiled at 2024-10-13
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: e941ee15be775fe3c46db1bed9b4f41c7dfb1334
active boot switches: -d:release

Does not build:

Nim Compiler Version 2.2.0 [Linux: amd64]
Compiled at 2024-10-13
Copyright (c) 2006-2024 by Andreas Rumpf

git hash: 78983f1876726a49c69d65629ab433ea1310ece1
active boot switches: -d:release

Nim Compiler Version 2.2.1 [Linux: amd64]
Compiled at 2024-10-13
Copyright (c) 2006-2024 by Andreas Rumpf

git hash: 720d0aee5c2d56260587f9ab09220d18ab9b53f7
active boot switches: -d:release

Current Output

/tmp/n.nim(2, 21) Error: type mismatch: got 'cstring' for '""' but expected 'string'

Expected Output

No response

Known Workarounds

No response

Additional Information

No response
@tersec tersec changed the title Regression from v2.0.10 to 2.2/devel in const with cstring/string literal conversion: context: n.nim(2, 21) Error: type mismatch: got 'cstring' for '""' but expected 'string'` Regression from v2.0.10 to 2.2/devel in const with cstring/string literal conversion: context: n.nim(2, 21) Error: type mismatch: got 'cstring' for '""' but expected 'string' Oct 13, 2024
@tersec tersec mentioned this issue Oct 13, 2024
Closed
@ringabout
Copy link
Member

!nim c

template g(_: int): string = ""
const c: cstring = 0.g()

@github-actions GitHub Actions
Copy link
Contributor

🐧 Linux bisect by @ringabout (member)
devel 👎 FAIL

Output

IR

Compiled filesize 0 (0 bytes) 


Stats
    

  • Started	2024-10-13T06:54:49

  • Finished	2024-10-13T06:54:49

  • Duration	


AST


nnkStmtList.newTree(
  nnkTemplateDef.newTree(
    newIdentNode("g"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newIdentNode("string"),
      nnkIdentDefs.newTree(
        newIdentNode("_"),
        newIdentNode("int"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newLit("")
    )
  ),
  nnkConstSection.newTree(
    nnkConstDef.newTree(
      newIdentNode("c"),
      newIdentNode("cstring"),
      nnkCall.newTree(
        nnkDotExpr.newTree(
          newLit(0),
          newIdentNode("g")
        )
      )
    )
  )
)




stable	👎 FAIL
Output






IR
Compiled filesize	0 (0 bytes)



Stats
    

  • Started	2024-10-13T06:54:52

  • Finished	2024-10-13T06:54:53

  • Duration	


AST


nnkStmtList.newTree(
  nnkTemplateDef.newTree(
    newIdentNode("g"),
    newEmptyNode(),
    newEmptyNode(),
    nnkFormalParams.newTree(
      newIdentNode("string"),
      nnkIdentDefs.newTree(
        newIdentNode("_"),
        newIdentNode("int"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newLit("")
    )
  ),
  nnkConstSection.newTree(
    nnkConstDef.newTree(
      newIdentNode("c"),
      newIdentNode("cstring"),
      nnkCall.newTree(
        nnkDotExpr.newTree(
          newLit(0),
          newIdentNode("g")
        )
      )
    )
  )
)




2.0.10	👍 OK
Output






IR
Compiled filesize	92.80 Kb (95,032 bytes)

#include "nimbase.h"
N_LIB_PRIVATE N_NIMCALL(void, nimTestErrorFlag)(void);
N_LIB_PRIVATE N_NIMCALL(void, atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus2dot0dot10atslibatssystemdotnim_Init000)(void);
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void);
N_LIB_PRIVATE void PreMainInner(void) {
}
N_LIB_PRIVATE int cmdCount;
N_LIB_PRIVATE char** cmdLine;
N_LIB_PRIVATE char** gEnv;
N_LIB_PRIVATE void PreMain(void) {
#if 0
 void (*volatile inner)(void);
 inner = PreMainInner;
 atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus2dot0dot10atslibatssystemdotnim_Init000();
 (*inner)();
#else
 atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus2dot0dot10atslibatssystemdotnim_Init000();
 PreMainInner();
#endif
}
N_LIB_PRIVATE N_CDECL(void, NimMainInner)(void) {
 NimMainModule();
}
N_CDECL(void, NimMain)(void) {
#if 0
 void (*volatile inner)(void);
 PreMain();
 inner = NimMainInner;
 (*inner)();
#else
 PreMain();
 NimMainInner();
#endif
}
int main(int argc, char** args, char** env) {
 cmdLine = args;
 cmdCount = argc;
 gEnv = env;
 NimMain();
 return nim_program_result;
}
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void) {
{
 nimTestErrorFlag();
}
}


Stats
    

  • Started	2024-10-13T06:54:56

  • Finished	2024-10-13T06:54:57

  • Duration	




2.0.0	👍 OK
Output






IR
Compiled filesize	90.64 Kb (92,816 bytes)

#include "nimbase.h"
N_LIB_PRIVATE N_NIMCALL(void, nimTestErrorFlag)(void);
N_LIB_PRIVATE N_NIMCALL(void, atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus2dot0dot0atslibatssystemdotnim_Init000)(void);
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void);
N_LIB_PRIVATE void PreMainInner(void) {
}
N_LIB_PRIVATE int cmdCount;
N_LIB_PRIVATE char** cmdLine;
N_LIB_PRIVATE char** gEnv;
N_LIB_PRIVATE void PreMain(void) {
#if 0
 void (*volatile inner)(void);
 inner = PreMainInner;
 atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus2dot0dot0atslibatssystemdotnim_Init000();
 (*inner)();
#else
 atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus2dot0dot0atslibatssystemdotnim_Init000();
 PreMainInner();
#endif
}
N_LIB_PRIVATE N_CDECL(void, NimMainInner)(void) {
 NimMainModule();
}
N_CDECL(void, NimMain)(void) {
#if 0
 void (*volatile inner)(void);
 PreMain();
 inner = NimMainInner;
 (*inner)();
#else
 PreMain();
 NimMainInner();
#endif
}
int main(int argc, char** args, char** env) {
 cmdLine = args;
 cmdCount = argc;
 gEnv = env;
 NimMain();
 return nim_program_result;
}
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void) {
{
 nimTestErrorFlag();
}
}


Stats
    

  • Started	2024-10-13T06:54:59

  • Finished	2024-10-13T06:55:00

  • Duration	




1.6.20	👍 OK
Output






IR
Compiled filesize	95.50 Kb (97,792 bytes)

#include "nimbase.h"
#define nimfr_(x, y)
#define nimln_(x, y)
static N_INLINE(void, initStackBottomWith)(void* locals);
N_LIB_PRIVATE N_NOINLINE(void, nimGC_setStackBottom)(void* theStackBottom);
N_LIB_PRIVATE N_NIMCALL(void, atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus1dot6dot20atslibatssystemdotnim_DatInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus1dot6dot20atslibatssystemdotnim_Init000)(void);
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void);
static N_INLINE(void, initStackBottomWith)(void* locals) {
 nimGC_setStackBottom(locals);
}
N_LIB_PRIVATE void PreMainInner(void) {
}
 N_LIB_PRIVATE int cmdCount;
 N_LIB_PRIVATE char** cmdLine;
 N_LIB_PRIVATE char** gEnv;
N_LIB_PRIVATE void PreMain(void) {
 void (*volatile inner)(void);
 inner = PreMainInner;
 atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus1dot6dot20atslibatssystemdotnim_DatInit000();
 initStackBottomWith((void *)&inner);
 atmdotdotatsdotdotatsdotdotatsdotchoosenimatstoolchainsatsnimminus1dot6dot20atslibatssystemdotnim_Init000();
 (*inner)();
}
N_LIB_PRIVATE N_CDECL(void, NimMainInner)(void) {
 NimMainModule();
}
N_CDECL(void, NimMain)(void) {
 void (*volatile inner)(void);
 PreMain();
 inner = NimMainInner;
 initStackBottomWith((void *)&inner);
 (*inner)();
}
int main(int argc, char** args, char** env) {
 cmdLine = args;
 cmdCount = argc;
 gEnv = env;
 NimMain();
 return nim_program_result;
}
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void) {
{
}
}


Stats
    

  • Started	2024-10-13T06:55:02

  • Finished	2024-10-13T06:55:03

  • Duration	




1.4.8	👍 OK
Output






IR
Compiled filesize	91.16 Kb (93,344 bytes)

#include "nimbase.h"
#define nimfr_(x, y)
#define nimln_(x, y)
static N_INLINE(void, initStackBottomWith)(void* locals);
N_LIB_PRIVATE N_NOINLINE(void, nimGC_setStackBottom)(void* theStackBottom);
N_LIB_PRIVATE N_NIMCALL(void, systemDatInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, systemInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void);
static N_INLINE(void, initStackBottomWith)(void* locals) {
 nimGC_setStackBottom(locals);
}
N_LIB_PRIVATE void PreMainInner(void) {
}
N_LIB_PRIVATE int cmdCount;
N_LIB_PRIVATE char** cmdLine;
N_LIB_PRIVATE char** gEnv;
N_LIB_PRIVATE void PreMain(void) {
 void (*volatile inner)(void);
 inner = PreMainInner;
 systemDatInit000();
 initStackBottomWith((void *)&inner);
 systemInit000();
 (*inner)();
}
N_LIB_PRIVATE N_CDECL(void, NimMainInner)(void) {
 NimMainModule();
}
N_CDECL(void, NimMain)(void) {
 void (*volatile inner)(void);
 PreMain();
 inner = NimMainInner;
 initStackBottomWith((void *)&inner);
 (*inner)();
}
int main(int argc, char** args, char** env) {
 cmdLine = args;
 cmdCount = argc;
 gEnv = env;
 NimMain();
 return nim_program_result;
}
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void) {
{
}
}


Stats
    

  • Started	2024-10-13T06:55:05

  • Finished	2024-10-13T06:55:05

  • Duration	




1.2.18	👍 OK
Output






IR
Compiled filesize	86.88 Kb (88,968 bytes)

#include "nimbase.h"
#define nimfr_(x, y)
#define nimln_(x, y)
static N_INLINE(void, initStackBottomWith)(void* locals);
N_LIB_PRIVATE N_NOINLINE(void, nimGC_setStackBottom)(void* theStackBottom);
N_LIB_PRIVATE N_NIMCALL(void, systemDatInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, systemInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void);
static N_INLINE(void, initStackBottomWith)(void* locals) {
 nimGC_setStackBottom(locals);
}
N_LIB_PRIVATE void PreMainInner(void) {
}
N_LIB_PRIVATE int cmdCount;
N_LIB_PRIVATE char** cmdLine;
N_LIB_PRIVATE char** gEnv;
N_LIB_PRIVATE void PreMain(void) {
 void (*volatile inner)(void);
 inner = PreMainInner;
 systemDatInit000();
 initStackBottomWith((void *)&inner);
 systemInit000();
 (*inner)();
}
N_LIB_PRIVATE N_CDECL(void, NimMainInner)(void) {
 NimMainModule();
}
N_CDECL(void, NimMain)(void) {
 void (*volatile inner)(void);
 PreMain();
 inner = NimMainInner;
 initStackBottomWith((void *)&inner);
 (*inner)();
}
int main(int argc, char** args, char** env) {
 cmdLine = args;
 cmdCount = argc;
 gEnv = env;
 NimMain();
 return nim_program_result;
}
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void) {
{
}
}


Stats
    

  • Started	2024-10-13T06:55:07

  • Finished	2024-10-13T06:55:07

  • Duration	




1.0.10	👍 OK
Output






IR
Compiled filesize	81.98 Kb (83,952 bytes)

#include "nimbase.h"
#define nimfr_(x, y)
#define nimln_(x, y)
static N_INLINE(void, initStackBottomWith)(void* locals);
N_NOINLINE(void, nimGC_setStackBottom)(void* theStackBottom);
N_LIB_PRIVATE N_NIMCALL(void, systemDatInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, systemInit000)(void);
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void);
static N_INLINE(void, initStackBottomWith)(void* locals) {	nimGC_setStackBottom(locals);
}
void PreMainInner(void) {
}
int cmdCount;
char** cmdLine;
char** gEnv;
void PreMain(void) {
 void (*volatile inner)(void);
 inner = PreMainInner;
 systemDatInit000();
 initStackBottomWith((void *)&inner);
 systemInit000();
 (*inner)();
}
N_CDECL(void, NimMainInner)(void) {
 NimMainModule();
}
N_CDECL(void, NimMain)(void) {
 void (*volatile inner)(void);
 PreMain();
 inner = NimMainInner;
 initStackBottomWith((void *)&inner);
 (*inner)();
}
int main(int argc, char** args, char** env) {
 cmdLine = args;
 cmdCount = argc;
 gEnv = env;
 NimMain();
 return nim_program_result;
}
N_LIB_PRIVATE N_NIMCALL(void, NimMainModule)(void) {
{
}
}


Stats
    

  • Started	2024-10-13T06:55:09

  • Finished	2024-10-13T06:55:09

  • Duration	




#eba87c7e9 ➡️ 🐛
Diagnostics


pylgos introduced a bug at 2023-11-22 15:50:38 +0900 on commit #eba87c7e9 with message:


fixes #22971; `inferGenericTypes` does not work with method call syntax (#22972)

fixes #22971



The bug is in the files:


compiler/semexprs.nim
tests/generics/treturn_inference.nim



The bug can be in the commits:



(Diagnostics sometimes off-by-one).


Stats
    

  • GCC	11.4.0

  • Clang	14.0.0

  • NodeJS	20.4

  • Created	2024-10-13T06:54:24Z

  • Comments	1

  • Commands	nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim


🤖 Bug found in 58 mins bisecting 964 commits at 17 commits per second

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @ringabout
ringabout



    mentioned this issue
    
      Oct 13, 2024
    





  


  

      
   Merged

  







  









      

  
      



  

  @metagn





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

      

      
            metagn
  

      

      

      commented


        Oct 13, 2024


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
This is weird, why does proc work but template doesn't?


Edit: Oh, the types are inverted here:



  

    

      Nim/compiler/sem.nim
    

    

        Lines 497 to 498
      in
      71515bf
    

  

  

    


        

          
           result = semExpr(c, result, flags, expectedType) 
        


        

          
           result = fitNode(c, retType, result, result.info) 
        

    

  






It infers it as cstring first then tries to convert it to string.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    


    

    

      
    

    


      

          @Araq
Araq




            closed this as completed
  in
    
      80e6b35
    


      Oct 13, 2024

    

  


    


  
  


  
    
  
  

    
  narimiran 

      pushed a commit
      that referenced
      this issue

    
      Oct 23, 2024
    
    

      


  

    

      


  

      
        @ringabout
      
        @narimiran
  





      

        
          templates/macros use no expected types when return types are specified (
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          fd9d2f5
        
      

    

  

    

      
#24298)

fixes #24296
fixes #24295

Templates use `expectedType` for type inference. It's justified that
when templates don't have an actual return type, i.e., `untyped` etc.

When the return type of templates is specified, we should not infer the
type

```nim
template g(): string = ""

let c: cstring = g()
```
In this example, it is not reasonable to annotate the templates
expression with the `cstring` type before the `fitNode` check with its
specified return type.

(cherry picked from commit 80e6b35)

    




    

  




  

  

    
  


  

      

    @tersec
tersec



    mentioned this issue
    
      Dec 8, 2024
    





  


  

      
  
  Closed

  







  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      templates/macros use no expected types when return types are specified

    
      nim-lang/Nim
    





    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @metagn 
        
          @tersec 
        
          @ringabout