finally: with multiple expressions in a single line doesn't work as expected

[gradha]

The following code compiles:

import db_sqlite, os

proc cleaners(name: string) =
  var conn = db_sqlite.open(name, "user", "pass", "db")
  conn.exec(sql"""CREATE TABLE IF NOT EXISTS tests (
    id INTEGER PRIMARY KEY,
    data TEXT NOT NULL)""")

  finally: conn.close(); removeFile(name)
  echo "Going to insert stuff..."
  conn.exec(sql"INSERT INTO tests (data) VALUES (?)", "test string")
  echo "Inserted!"


when isMainModule:
  cleaners("test.db")

However, it fails to run with the following output:

Going to insert stuff...
Traceback (most recent call last)
dbfail.nim(16)           dbfail
dbfail.nim(9)            cleaners
db_sqlite.nim(181)       Close
db_sqlite.nim(41)        dbError
Error: unhandled exception: unable to close due to unfinalised statements [EDb]
Error: execution of an external program failed

The problem is with the finally having more than one statement in a single line. The example works as expected if I rewrite that part as:

  finally:
    conn.close()
    removeFile(name)

The ; is clearly evil.

[gradha]

Hmm... so the problem is the ; in a single line makes the removeFile execute out of the finally context, and then the next sqlite command fails likely due to being unable to lock the removed database file. Not sure if this counts as a bug then, will the new parser take this in mind or will you need parenthesis around both statements for it to work as expected? If not, maybe the parser should warn about this behaviour of finally: on a single line or simply not compile it?

[dom96]

Fixed by 255b4d9