[ospaths, os] miscellaneous issues

[timotheecour]

• [ospaths] BUG: parentDir("a/b//")==a/b (but parentDir("a/b/") == a is OK) [TODO] bugs with parentDir #8734
  => use normalizePathEnd
• make extractFilename("~bob") work
• reconsider: [Improvement] [Issue 9200] Add recursive argument to removeDir procedure [Improvement] [Issue 9200] Add recursive argument to removeDir procedure #9215
• https://github.com/nim-lang/Nim/issues/8268 joinPath("foo", "/bar") should return "/bar"
• [ospaths] toSeq(parentDirs("/a/b")) returns @["/a/b", "/a", ""] instead of @["/a/b", "/a", "/"] (last entry wrong) [ospaths] toSeq(parentDirs("/a/b")) returns @["/a/b", "/a", ""] instead of @["/a/b", "/a", "/"] (last entry wrong) #8353
• make sure we have:
  doAssert lastPathPart(r"C:") == ""
  doAssert lastPathPart(r"C:") == ""
  doAssert extractFilename(r"C:") == ""
• deprecate expandFilename : expandFilename doesn't just apply on files but also on dirs so it's badly named; also it's not as useful as realPath (cf unix cmd line realpath or python os.realpath):
  in python, it resolves symlinks, makes it absolute dir, and doesn't throw on un-existant paths, instead resolves the maximum prefix then appends the suffix, eg:
• function for realpath (see unix realpath ; perhaps extracting that out from implementation of findExe which may be doing that at the end)
  Related to that expandFilename works only on existing files and directories. #6486
• pathMatches => see closed PR: Add os.pathMatches proc Add os.pathMatches proc #7836

find /foo/bar
/foo/bar/existing
ln -sf /foo/bar mysymlink

os.path.realpath('mysymlink/existing/unexistant_dir/unexistant_file')
/foo/bar/existing/unexistant_dir/unexistant_file

• function for which prog see [TODO] findExe should have an option to match unix which (and python shutil.which) behavior (cwd not searched, and by default symlinks not followed) #8311
• function for unix stat (or python os.stat, or D's std.file. DirEntry)
• possibly a bug in ospaths causes [TODO] wrong path handling in error message nimble#516
• os.tailDir fails on some paths #8395 ospaths: tailDir("/usr/local/bin") should be "usr/local/bin" instead of "local/bin" (because of /) os.tailDir fails on some paths #8395
• [ospaths] BUG: splitFile("/a.txt").dir = "" ; + other bugs with splitFile #8255 [ospaths] BUG: splitFile("/a.txt") returns (dir: "", name: "a", ext: ".txt") [ospaths] BUG: splitFile("/a.txt").dir = "" ; + other bugs with splitFile #8255
• relativePath (same as https://dlang.org/phobos/std_path.html#relativePath)
  see Add relativePath proc and test #8166 pull request to add getRelativePathFromAbsolute proc
• [ospaths] cmpPaths("abc/def", "abc//def") returns !=0; should return 0 [ospaths] cmpPaths("abc/def", "abc//def") returns !=0; should return 0 #8780
• BUG: os.isHidden doesn't work with directories; should use just paths, not filesystem access #8225 BUG: os.isHidden doesn't work with directories; should use just paths, not filesystem access BUG: os.isHidden doesn't work with directories; should use just paths, not filesystem access #8225
  => PR fix #8225 os.isHidden was buggy on posix #8315
• [RFC] extractFilename("usr/lib/") should return "lib" (not "") and be called baseName (since works with dirs) [RFC] extractFilename("usr/lib/") should return "lib" (not "") and be called baseName (since works with dirs) #8341 => see fix in PR fix #8341: add lastPathPart #9116
• ospaths.expandTilde doesn't handle ~ correctly, see PR ospaths.expandTilde: handle ~ correctly; refactor to use DirSep, AltSep #8364
• [ospaths] ospaths.nim says OSX is FileSystemCaseSensitive:true but should be false ; cmpPaths seems wrong #8349 [ospaths] ospaths.nim says OSX is FileSystemCaseSensitive:true but should be false ; cmpPaths seems wrong
• ospaths.isAbsolute: uncovering out of bound bugs after updating to 0.18.1 from 0.18.0: empty string and nil string now checked for out of bound errors #8251 ospaths.isAbsolute out of bound bug
• missing ospaths.absolutePath function to get absolute path from a path #8174 missing ospaths.absolutePath function to get absolute path from a path missing ospaths.absolutePath function to get absolute path from a path #8174
  EDIT PR: add os.absolutePath; fixes #8174 #8213
• BUG: toSeq("foo/.".parentDirs) returns @["foo/.", "foo"] instead of @["foo"] ; similarly confused with ".." in path

minor

• getEnv + friends has nothing to do with ospaths, should be in a different module (imported by ospaths since it uses getHomeDir)
• buildNormalizedPath (same as https://dlang.org/phobos/std_path.html#buildNormalizedPath)
  EDIT see Add normalizePath and tests #6587 (comment) ; but should be in ospaths, not os; (see Add normalizePath and tests #6587 (review))
  also, normalizedPath("/../../../") == "/" currently instead of throwing, not sure if desired (cf https://github.com/nim-lang/Nim/pull/6587/files#r200625795)

related

• expandFilename works only on existing files and directories. #6486 expandFilename work only on existing files and directories. expandFilename works only on existing files and directories. #6486

[demotomohiro]

Related pull requests:
#6587 pull request to add normalizePath, absolutePath, but failed test and not merged.
#8166 pull request to add getRelativePathFromAbsolute proc