Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ospaths] cmpPaths("abc/def", "abc//def") returns !=0; should return 0 #8780

Closed
timotheecour opened this issue Aug 25, 2018 · 5 comments
Closed

[ospaths] cmpPaths("abc/def", "abc//def") returns !=0; should return 0 #8780

timotheecour opened this issue Aug 25, 2018 · 5 comments
Labels
OS (stdlib) Related to OS modules in standard library Standard Library

Comments

@timotheecour
Copy link
Member

No description provided.

This was referenced Aug 25, 2018
Merged
Open
@mratsim
Copy link
Collaborator

mratsim commented Aug 26, 2018

Maybe we should have a Path "distinct string" type that stores validated canonical paths.

@Araq
Copy link
Member

Araq commented Aug 26, 2018

Paths as a separate distinct string type make more and more sense, but let's also fix what we got.

@mratsim
Copy link
Collaborator

mratsim commented Sep 8, 2018

Relevant: https://irclogs.nim-lang.org/06-09-2018.html#14:17:36

@timotheecour
Copy link
Member Author

@mratsim

Maybe we should have a Path "distinct string" type that stores validated canonical paths.

see: [WIP] [RFC] new path handling module that uses Nim's type system, using Path instead of string #8362

@timotheecour timotheecour added the OS (stdlib) Related to OS modules in standard library label Oct 25, 2018
@timotheecour
Copy link
Member Author

/cc @Araq closing this, looks like recent changes fixed this (cmpPaths now uses normalizePath)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS (stdlib) Related to OS modules in standard library Standard Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dom96 @Araq @timotheecour @mratsim