[TODO] profiler improvements #10119
Closed
[TODO] profiler improvements #10119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
timotheecour
force-pushed
the
pr_nimprof_fixes
branch
2 times, most recently
from
d15fdc9
to
cba74d7
Compare
krux02
reviewed
Jan 9, 2019
| if pointer(x) == pointer(y): result = true | ||
| elif x.isNil or y.isNil: result = false | ||
| else: result = strcmp(x, y) == 0 | ||
|
|
There was a problem hiding this comment.
is this still a letfover, I don't see you use it anywhere.
There was a problem hiding this comment.
that's the fix for #10106 ; without it it fails:
nim c --profiler:on compiler/nim.nim
compiler/nim c -o:/tmp/z01 compiler/nim.nim
fails with error msg here #10106 (comment)
There was a problem hiding this comment.
This is not a fix, it's workaround and I don't like it.
* add line to stacktrace in profiler results
timotheecour
force-pushed
the
pr_nimprof_fixes
branch
from
cba74d7
to
6b9fb6f
Compare
|
It works around the underlying problem. |
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Araq @zah
add line to stacktrace in profiler results
fixes can't profile nim compiler #10106
remove duplicate
type StackTrace = objectdefinitionnote to reviewer: not sure where/when this was used, maybe I overlook some use case?
minor bugfix in "for i in 0..<min(100, entries)" (previously printed 101 entries unlike what comment suggested)
Note: the fix for #10106 works but leads to code duplication; alternatives would be:
{.pushAcrossModuleBoundary profiler: off.}as proposed here: {.pushAcrossModuleBoundary profiler: off.} to push a compilation option all the way down #10120