Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for #7976 #10169

Closed
wants to merge 2 commits into from

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jan 2, 2019

note1

I'm using the same technique here as I had introduced here #9927
it allows grouping tests in a single self contained file instead of splitting in multiple files (see also rationale here: see rationale here: #9927 (comment))

I've read this comment #9927 (comment) but testament doesn't support this, and the pattern is simple and gives fine grained control to test writer.

note2:

see tests/issues/readme.md for rationale why I'm adding this directory; my intent is to also use it for https://github.com/nim-lang/Nim/issues/10170

@timotheecour timotheecour force-pushed the pr_testcase_7976 branch 2 times, most recently from 4870d95 to 3afffb0 Compare January 2, 2019 22:05
@Araq
Copy link
Member

Araq commented Jan 4, 2019

Issue numbers have no semantics, I don't like this at all. Extract the test file name from the issue title instead.

@krux02
Copy link
Contributor

krux02 commented Feb 20, 2019

Things I don't like about this PR

  • sneaking in a new file: tests/helper_testament.nim for no reason at all
  • when defined(caseX) pattern
  • calling the compiler to compile the test from the test
  • No explanation in the test on what the test is actually testing

not joinable tests woul work equally well.
Then I am not sure if the behavior that is tested here should be engraved in stone.

@Araq Araq closed this Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[typetraits] Tuple type name confusion
3 participants