Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [testament] compile/run compiler/** #10351

Closed

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jan 17, 2019

before PR:

  • not all compiler sources are used when building nim from compiler sources
  • isMainModule tests in compiler sources are not actually being tested

after PR:

  • same treatment as stdlib
  • helps find dead code automatically (eg compiler/canonicalizer.nim doesn't seem used anymore, and doesn't compile)
  • helps find/fix issues eg:
    replaced assert st.getOrDefault("www.harvardsucks.com") == nil to == "" to make compiler/btrees.nim pass

other changes in this PR

  • now show action (eg : run/compile etc) in PASS/FAIL msgs eg:
    PASS: compiler/bitsets.nim C compile ( 1.56246400 secs)

note

@timotheecour timotheecour force-pushed the pr_testament_compiler branch from 9c1f294 to 93f8479 Compare January 18, 2019 00:37
@Araq
Copy link
Member

Araq commented Feb 8, 2019

I'd rather do it my way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants