fix #10053: FieldError exception messages now show discriminant + type #11951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before PR:
Error: unhandled exception: f2 [FieldError]
in most cases (eg see error msg i got from #11947) this is not very helpful
after PR:
Error: unhandled exception: 'f2' is not accessible using discriminant 'kind' of type 'Foo' [FieldError]
works with
nim js
andnim c
note
I have another PR to fix the VM case, but it depends on this PR so i'll wait until this is merged