Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #12152 #12165

Merged
merged 2 commits into from
Sep 11, 2019
Merged

fixes #12152 #12165

merged 2 commits into from
Sep 11, 2019

Conversation

Araq
Copy link
Member

@Araq Araq commented Sep 10, 2019

No description provided.

@awr1
Copy link
Contributor

awr1 commented Sep 11, 2019

Is there a good reason why all these tests aren't in their own test module?

@Araq
Copy link
Member Author

Araq commented Sep 11, 2019

It can be more convenient to touch a stdlib module and to know its tests are in the same file and a single nim c -r file_i_just_touched.nim away.

@Araq Araq merged commit e134a72 into devel Sep 11, 2019
@Araq Araq deleted the araq-fixes-12152 branch September 11, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araq @awr1