Fixes #10514 #12268
Merged
Fixes #10514 #12268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test case failure happens because now the compiler is more correct: const SOMECONST = 0.int
let SOMELET = 0.int
var SOMEVAR = 0.int
proc echoInt32(i: int32) =
echo i
echoInt32(SOMECONST) #Will be illegal with this PR
echoInt32(SOMELET) #Already illegal
echoInt32(SOMEVAR) #Already illegal |
|
PR to correct it in the package: GULPF/tiny_sqlite#1 |
(cherry picked from commit f6f789b)
rayman22201
pushed a commit
to rayman22201/Nim
that referenced
this pull request
Oct 4, 2019
* Fixes nim-lang#10514 (cherry picked from commit f6f789b) * Add comment * Add changelog entry
alehander92
pushed a commit
to alehander92/Nim
that referenced
this pull request
Dec 2, 2019
* Fixes nim-lang#10514 (cherry picked from commit f6f789b) * Add comment * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot of #10515
Credit goes to LemonBoy