fix #11764, faster hashing of (u)int #12407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running https://github.com/cwpearson/nim-issue-11764/blob/master/slow_set.nim on my machine, which is the test case for #11764 produces the following before/after results:
Before this PR:
After this PR:
Summary: this PR makes HashSets and HashTables about three orders of magnitude faster for large amounts of (u)int keys, because it prevents huge amounts of collisions happening with the old algorithm (where the hash of an int was that int) for consecutive ints.