Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] increase the timeout for 'tasyncclosestall' #12744

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

narimiran
Copy link
Member

This test is very flaky, this change might help reducing the
number of failings (usually solved by restarting the test suite).

Refs #12694 (comment)

This test is very flaky, this change might help reducing the
number of failings (usually solved by restarting the test suite).

Refs nim-lang#12694 (comment)
@narimiran narimiran requested a review from dom96 November 26, 2019 09:54
@narimiran narimiran changed the title increase the timeout for 'tasyncclosestall' [backport] increase the timeout for 'tasyncclosestall' Nov 26, 2019
@Araq Araq merged commit 879801c into nim-lang:devel Nov 26, 2019
@narimiran narimiran deleted the less-flaky branch November 26, 2019 14:34
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth increasing it even further (maybe up to 60 secs), IIRC that timeout is the worst case scenario if the test fails. So as long as the test is succeeding it should be faster than this, but you might want to verify this.

@narimiran
Copy link
Member Author

Might be worth increasing it even further (maybe up to 60 secs)

Ok, I'll keep the eye on the test and if it is still failing I'll keep increasing it.

alehander92 pushed a commit to alehander92/Nim that referenced this pull request Dec 2, 2019
This test is very flaky, this change might help reducing the
number of failings (usually solved by restarting the test suite).

Refs nim-lang#12694 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants