[superseded] fix #12996

[timotheecour]

• fix regression(1.04) invalid pragma: since with nim js #12996
• the alternative is to add include "system/inclrtl" (even for nim js) to strtabs.nim but IMO since does not belong in inclrtl:

# Pragmas for RTL generation. Has to be an include, because user-defined
# pragmas cannot be exported.

[Araq]

I understand the desire to put it into system.nim, but I don't understand #12996 yet so please be a little patient. :-)

[timotheecour]

The bug is simple: include inclrtl is only enabled for non js target, so since is not visible in js mode, hence the regression

[Araq]

Why not include it all the time then?

[timotheecour]

well that's the alternative i had written up in top post:

the alternative is to add include "system/inclrtl" (even for nim js) to strtabs.nim but IMO since does not belong in inclrtl:

but as i mentioned, it's not so good to include inclrtl especially since it has nothing to do with inclrtl (and include is a code smell IMO).

related question: I never understood the rationale for : pragmas cannot be exported
is there a fundamental reason for this limitation or it's just a matter of someone implementing export pragmas?

[Araq]

Well since is for Nim's stdlib, not for anybody else and so it shouldn't be exported from system.nim. The stdlib should include what it needs instead, JS target or not.

I never understood the rationale for : pragmas cannot be exported
is there a fundamental reason for this limitation or it's just a matter of someone implementing export pragmas?

Looks somewhat hard to implement but more importantly, I considered {.pragma.} a hack until templates pragmas worked. And now they do work.

[timotheecour]

Well since is for Nim's stdlib, not for anybody else and so it shouldn't be exported from system.nim. The stdlib should include what it needs instead, JS target or not.

good point regarding not making since public; this is actually a perfect example of the need for {. privateImport.} (see #11865 which I just rebased).

As a concrete example, see how this would play out here with since added privately to system.nim: timotheecour@643a326

# in strtabs.nim:
from system {.privateImport.} import since

besides removing most needs for include, making testing easier and other benefits I mentioned in top post of that PR, this would actually help un-bloat system.nim in similar ways.

[Araq]

I fixed it differently.

[timotheecour]

superseded by #14188