Fix OS detection in a docker container

[EchoPouet]

Hello,

I create this request to fix the OS detection in the docker containers. distros module use the command uname -a to get the OS name but in a docker container the value returned is not the container OS but the host OS.

So it's why I changed the code to use the command cat /etc/os-release | grep ^ID= to get the OS ID (see https://www.cyberciti.biz/faq/how-to-check-os-version-in-linux-command-line/). The OS ID is normally unique. An example with a CentOS container run in Ubuntu (the host):

root@bubuntu: docker run -t -i --rm centos bash
[root@95af48f1547c /]# uname -a
Linux 95af48f1547c 5.3.0-24-generic #26~18.04.2-Ubuntu SMP Tue Nov 26 12:34:22 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
[root@95af48f1547c /]# cat /etc/os-release | grep ^ID=
ID="centos"

I tested this fix in following OS:

• Elementary,
• Ubuntu,
• Debian,
• Fedora,
• OpenMandriva,
• CentOS
• Alpine,
• Mageia,
• Zorin,
• RedHat,
• ArchLinux.

Also, I created a test to check if the OS detection is good. It's very simple but it exists.

Thanks

[Araq]

Huh? That cannot be correct for Haiku and the BSDs...

[Araq]

Really nice job, but please somehow ensure you only changed the logic for the OSes that you have tested it for.

[EchoPouet]

Thank you but I don't know why I change the detection for Haiku and BSD. Maybe a merge error :)

[EchoPouet]

Can I expected this fix merged in the next release ? Because I work every-time in docker (CI/CD use docker also) and I would like remove this fix in my code.

Thanks

[Araq]

I would love to merge it but please ensure the BSDs keep working.

[EchoPouet]

Ho I missed your request, I'm going to test my change in BSD.