Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[superseded] fix #13513 +% now gives correct values in semfold + VM #13532

Closed

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 28, 2020

[EDIT] this fixes #13513 but breaks other tests, I need to think more... marked as WIP

@timotheecour timotheecour force-pushed the pr_fix_13513_narrow_int branch from fa9b707 to f3e3e87 Compare February 28, 2020 15:47
@timotheecour timotheecour changed the title fix #13513 +% now gives correct values in semfold + VM [WIP] fix #13513 +% now gives correct values in semfold + VM Feb 28, 2020
@krux02
Copy link
Contributor

krux02 commented Feb 29, 2020

Well I took over here: #13536

Edit:
I just looked at what you did here. And no this can't work. You can't change the meaning of NarrowU it is used a lot in the VM and it has to be exactly what it is right now.

@krux02 krux02 closed this Feb 29, 2020
@timotheecour timotheecour changed the title [WIP] fix #13513 +% now gives correct values in semfold + VM [superseded] fix #13513 +% now gives correct values in semfold + VM Mar 11, 2020
@timotheecour timotheecour deleted the pr_fix_13513_narrow_int branch March 11, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler creates invalid out-of-range int8 constants.
2 participants